yuqi1129 commented on code in PR #4213:
URL: https://github.com/apache/gravitino/pull/4213#discussion_r1689084806
##########
trino-connector/src/main/java/org/apache/gravitino/trino/connector/system/storedprocdure/AlterCatalogStoredProcedure.java:
##########
@@ -140,7 +141,7 @@ public void alterCatalog(
} catch (Exception e) {
throw new TrinoException(
GravitinoErrorCode.GRAVITINO_UNSUPPORTED_OPERATION,
- "alter catalog failed. " + e.getMessage(),
+ "alter catalog failed. " + (StringUtils.isEmpty(e.getMessage()) ? ""
: e.getMessage()),
Review Comment:
I'm not very clear about the changes here, if `e.getMessage()` is empty or
null, the code changes seems be to the same as before.
##########
trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/CatalogConnectorManager.java:
##########
@@ -60,7 +60,7 @@ public class CatalogConnectorManager {
private static final int CATALOG_LOAD_FREQUENCY_SECOND = 10;
private static final int NUMBER_EXECUTOR_THREAD = 1;
- private static final int LOAD_METALAKE_TIMEOUT = 30;
+ private static final int LOAD_METALAKE_TIMEOUT = 60;
Review Comment:
Why do we increase this value? Is it really take so long to load metalake?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
