jerryshao commented on code in PR #4088:
URL: https://github.com/apache/gravitino/pull/4088#discussion_r1689223951


##########
iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/integration/test/IcebergRESTServiceIT.java:
##########
@@ -526,4 +519,42 @@ void testSnapshot() {
         convertToStringMap(sql("select * from 
iceberg_rest_table_test.snapshot_foo1"));
     Assertions.assertEquals(ImmutableMap.of("1", "a", "2", "b"), result);
   }
+
+  @Test
+  @EnabledIf("catalogTypeNotMemory")
+  void testRegisterTable() {
+    String registerDB = "iceberg_register_db";
+    String registerTableName = "register_foo1";
+    sql("CREATE DATABASE " + registerDB);
+    sql(
+        String.format(
+            "CREATE TABLE %s.%s (id bigint COMMENT 'unique id',data string) 
using iceberg",
+            registerDB, registerTableName));
+    sql(String.format("INSERT INTO %s.%s VALUES (1, 'a')", registerDB, 
registerTableName));
+
+    // get metadata location
+    List<String> metadataLocations =
+        convertToStringList(
+            sql(
+                String.format(
+                    "select file from %s.%s.metadata_log_entries", registerDB, 
registerTableName)),
+            0);
+    String metadataLocation = metadataLocations.get(metadataLocations.size() - 
1);
+
+    // register table
+    String register =
+        String.format(
+            "CALL rest.system.register_table(table => 
'iceberg_rest_table_test.register_foo2', metadata_file=> '%s')",
+            metadataLocation);
+    sql(register);
+
+    Map<String, String> result =
+        convertToStringMap(sql("select * from 
iceberg_rest_table_test.register_foo2"));
+    Assertions.assertEquals(ImmutableMap.of("1", "a"), result);
+
+    // insert other data
+    sql(" INSERT INTO iceberg_rest_table_test.register_foo2 VALUES (2, 'b')");

Review Comment:
   Remove the whitespace before "INSERT".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to