This is an automated email from the ASF dual-hosted git repository.

mchades pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git


The following commit(s) were added to refs/heads/main by this push:
     new dee9043be [MINOR] fix: Refine the comments within the 
createCatalogWrapper method (#4272)
dee9043be is described below

commit dee9043be8e4bfa9f7d2119b9d69a5fe23f5b69d
Author: RickyMa <[email protected]>
AuthorDate: Thu Jul 25 15:51:16 2024 +0800

    [MINOR] fix: Refine the comments within the createCatalogWrapper method 
(#4272)
    
    ### What changes were proposed in this pull request?
    
    Refine the comments within the `createCatalogWrapper` method.
    
    ### Why are the changes needed?
    
    Better readability.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    No need.
---
 .../main/java/org/apache/gravitino/catalog/CatalogManager.java    | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java 
b/core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java
index 574248f8e..66e0ea385 100644
--- a/core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java
+++ b/core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java
@@ -668,10 +668,10 @@ public class CatalogManager implements CatalogDispatcher, 
Closeable {
           validatePropertyForCreate(catalog.catalogPropertiesMetadata(), 
configWithoutId);
 
           // Call wrapper.catalog.properties() to make BaseCatalog#properties 
in IsolatedClassLoader
-          // not null. Why we do this? Because wrapper.catalog.properties() 
need to be called in the
-          // IsolatedClassLoader, it needs to load the specific catalog class 
such as HiveCatalog or
-          // so. For simply, We will preload the value of properties and thus 
AppClassLoader can get
-          // the value of properties.
+          // not null. Why do we do this? Because wrapper.catalog.properties() 
needs to be called in
+          // the IsolatedClassLoader, as it needs to load the specific catalog 
class
+          // such as HiveCatalog or similar. To simplify, we will preload the 
value of properties
+          // so that AppClassLoader can get the value of properties.
           wrapper.catalog.properties();
           wrapper.catalog.capability();
           return null;

Reply via email to