FANNG1 commented on code in PR #4265:
URL: https://github.com/apache/gravitino/pull/4265#discussion_r1694410555
##########
flink-connector/src/main/java/org/apache/gravitino/flink/connector/utils/TypeUtils.java:
##########
@@ -55,8 +129,80 @@ public static DataType toFlinkType(Type gravitinoType) {
return DataTypes.INT();
case LONG:
return DataTypes.BIGINT();
+ case FLOAT:
+ return DataTypes.FLOAT();
+ case SHORT:
+ return DataTypes.SMALLINT();
+ case DECIMAL:
+ Types.DecimalType decimalType = (Types.DecimalType) gravitinoType;
+ return DataTypes.DECIMAL(decimalType.precision(), decimalType.scale());
+ case VARCHAR:
+ Types.VarCharType varCharType = (Types.VarCharType) gravitinoType;
+ return DataTypes.VARCHAR(varCharType.length());
+ case FIXED:
+ Types.FixedType fixedType = (Types.FixedType) gravitinoType;
+ return DataTypes.CHAR(fixedType.length());
Review Comment:
fixed -> binary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
