yuqi1129 commented on code in PR #4268:
URL: https://github.com/apache/gravitino/pull/4268#discussion_r1694817296
##########
docs/trino-connector/requirements.md:
##########
@@ -7,7 +7,7 @@ license: "This software is licensed under the Apache License
version 2."
To install and deploy the Apache Gravitino connector, The following
environmental setup is necessary:
-- Trino server version should be at least Trino-server-435.
+- Trino server version should between Trino-server-435 and Trino-server-439.
Review Comment:
should -> should be
##########
trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/CatalogRegister.java:
##########
@@ -62,17 +64,31 @@ private void checkTrinoSpiVersion(ConnectorContext context)
{
this.trinoVersion = context.getSpiVersion();
int version = Integer.parseInt(context.getSpiVersion());
- if (version < MIN_TRINO_SPI_VERSION) {
+ if (version < MIN_SUPPORT_TRINO_SPI_VERSION || version >
MAX_SUPPORT_TRINO_SPI_VERSION) {
String errmsg =
String.format(
- "Unsupported Trino-%s version. min support version is Trino-%d",
- trinoVersion, MIN_TRINO_SPI_VERSION);
+ "Unsupported Trino-%s version. The Supported version for the
Gravitino-Trino-connector from Trino-%d to Trino-%d",
+ trinoVersion, MIN_SUPPORT_TRINO_SPI_VERSION,
MAX_SUPPORT_TRINO_SPI_VERSION);
throw new
TrinoException(GravitinoErrorCode.GRAVITINO_UNSUPPORTED_TRINO_VERSION, errmsg);
}
isCoordinator = context.getNodeManager().getCurrentNode().isCoordinator();
}
+ private void checkSupportCatalogNameWithMetalake(
+ ConnectorContext context, GravitinoConfig config) {
+ if (!config.simplifyCatalogNames()) {
+ int version = Integer.parseInt(context.getSpiVersion());
+ if (version < MIN_SUPPORT_CATALOG_NAME_WITH_METALAKE_TRINO_SPI_VERSION) {
+ String errmsg =
+ String.format(
+ "The Trino-%s version is not support catalog name with
metalake, The minimal required version is Trino-%d",
Review Comment:
Trino-%s does not support the catalog name with dots, the minimum version
required is xxxx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
