xunliu commented on code in PR #4239:
URL: https://github.com/apache/gravitino/pull/4239#discussion_r1696209844
##########
core/src/main/java/org/apache/gravitino/authorization/AuthorizationUtils.java:
##########
@@ -116,4 +123,65 @@ public static void checkRoleNamespace(Namespace namespace)
{
"Role namespace must have 3 levels, the input namespace is %s",
namespace);
}
+
+ public static <T> void prepareAuthorizationHooks(T manager, LifecycleHooks
hooks) {
Review Comment:
I think better to add some comments for this function.
##########
core/src/main/java/org/apache/gravitino/GravitinoEnv.java:
##########
@@ -375,4 +385,23 @@ private void initGravitinoServerComponents() {
// Tag manager
this.tagManager = new TagManager(idGenerator, entityStore);
}
+
+ // Provides a universal entrance to install lifecycle hooks. This method
+ // focuses the logic of installing hooks.
+ // We should reuse the ability of *NormalizeDispatcher to avoid solving
Review Comment:
Which mean is `*NormalizeDispatcher`, Typo?
`*NormalizeDispatcher*`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
