jerryshao commented on code in PR #4307:
URL: https://github.com/apache/gravitino/pull/4307#discussion_r1696506814
##########
catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/PaimonCatalogPropertiesMetadata.java:
##########
@@ -41,9 +41,9 @@
public class PaimonCatalogPropertiesMetadata extends
BaseCatalogPropertiesMetadata {
@VisibleForTesting public static final String GRAVITINO_CATALOG_BACKEND =
"catalog-backend";
- @VisibleForTesting public static final String PAIMON_METASTORE = "metastore";
- @VisibleForTesting public static final String WAREHOUSE = "warehouse";
- @VisibleForTesting public static final String URI = "uri";
+ public static final String PAIMON_METASTORE = "metastore";
+ public static final String WAREHOUSE = "warehouse";
+ public static final String URI = "uri";
Review Comment:
We can make them package public if it is possible, no need to change to
public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
