mchades commented on code in PR #4308:
URL: https://github.com/apache/gravitino/pull/4308#discussion_r1696876616
##########
api/src/main/java/org/apache/gravitino/tag/SupportsTags.java:
##########
@@ -58,6 +59,8 @@ public interface SupportsTags {
* @param tagsToAdd The arrays of tag name to be added to the object.
* @param tagsToRemove The array of tag name to be removed from the object.
* @return The array of tag names that are associated with the object.
+ * @throws TagAlreadyAssociatedException If the tag is already associated
with the object.
*/
- String[] associateTags(String[] tagsToAdd, String[] tagsToRemove);
+ String[] associateTags(String[] tagsToAdd, String[] tagsToRemove)
Review Comment:
If so, suggest adding comments to the API. Otherwise, some users may think
this is an asynchronous operation that allows users to bind tags before
creating them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
