mchades commented on code in PR #4261:
URL: https://github.com/apache/gravitino/pull/4261#discussion_r1698236651


##########
docs/gravitino-server-config.md:
##########
@@ -17,25 +17,26 @@ Apache Gravitino supports several configurations:
 ## Apache Gravitino server configurations
 
 You can customize the Gravitino server by editing the configuration file 
`gravitino.conf` in the `conf` directory. The default values are sufficient for 
most use cases.
-We strongly recommend that you read the following sections to understand the 
configuration file so you can change the default values to suit your specific 
situation and usage scenario.
+We strongly recommend that you read the following sections to understand the 
configuration file, so you can change the default values to suit your specific 
situation and usage scenario.
 
 The `gravitino.conf` file lists the configuration items in the following 
table. It groups those items into the following categories:
 
 ### Apache Gravitino HTTP Server configuration
 
-| Configuration item                                    | Description          
                                                                                
                                                                                
 | Default value                                                                
| Required | Since version |
-|-------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------|----------|---------------|
-| `gravitino.server.webserver.host`                     | The host of the 
Gravitino server.                                                               
                                                                                
      | `0.0.0.0`                                                               
     | No       | 0.1.0         |
-| `gravitino.server.webserver.httpPort`                 | The port on which 
the Gravitino server listens for incoming connections.                          
                                                                                
    | `8090`                                                                    
   | No       | 0.1.0         |
-| `gravitino.server.webserver.minThreads`               | The minimum number 
of threads in the thread pool used by the Jetty webserver. `minThreads` is 8 if 
the value is less than 8.                                                       
   | `Math.max(Math.min(Runtime.getRuntime().availableProcessors() * 2, 100), 
8)` | No       | 0.2.0         |
-| `gravitino.server.webserver.maxThreads`               | The maximum number 
of threads in the thread pool used by the Jetty webserver. `maxThreads` is 8 if 
the value is less than 8, and `maxThreads` must be great or equal to 
`minThreads`. | `Math.max(Runtime.getRuntime().availableProcessors() * 4, 400)` 
             | No       | 0.1.0         |
-| `gravitino.server.webserver.threadPoolWorkQueueSize`  | The size of the 
queue in the thread pool used by the Jetty webserver.                           
                                                                                
      | `100`                                                                   
     | No       | 0.1.0         |
-| `gravitino.server.webserver.stopTimeout`              | Time in milliseconds 
to gracefully shut down the Jetty webserver, for more, please see 
`org.eclipse.jetty.server.Server#setStopTimeout`.                               
               | `30000`                                                        
              | No       | 0.2.0         |
-| `gravitino.server.webserver.idleTimeout`              | The timeout in 
milliseconds of idle connections.                                               
                                                                                
       | `30000`                                                                
      | No       | 0.2.0         |
-| `gravitino.server.webserver.requestHeaderSize`        | Maximum size of HTTP 
requests.                                                                       
                                                                                
 | `131072`                                                                     
| No       | 0.1.0         |
-| `gravitino.server.webserver.responseHeaderSize`       | Maximum size of HTTP 
responses.                                                                      
                                                                                
 | `131072`                                                                     
| No       | 0.1.0         |
-| `gravitino.server.shutdown.timeout`                   | Time in milliseconds 
to gracefully shut down of the Gravitino webserver.                             
                                                                                
 | `3000`                                                                       
| No       | 0.2.0         |
-| `gravitino.server.webserver.customFilters`            | Comma-separated list 
of filter class names to apply to the API.                                      
                                                                                
 | (none)                                                                       
| No       | 0.4.0         |
+| Configuration item                                   | Description           
                                                                                
                                                                                
| Default value                                                                
| Required | Since version |
+|------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------|----------|---------------|
+| `gravitino.server.webserver.host`                    | The host of the 
Gravitino server.                                                               
                                                                                
      | `0.0.0.0`                                                               
     | No       | 0.1.0         |
+| `gravitino.server.webserver.httpPort`                | The port on which the 
Gravitino server listens for incoming connections.                              
                                                                                
| `8090`                                                                       
| No       | 0.1.0         |
+| `gravitino.server.webserver.minThreads`              | The minimum number of 
threads in the thread pool used by the Jetty webserver. `minThreads` is 8 if 
the value is less than 8.                                                       
   | `Math.max(Math.min(Runtime.getRuntime().availableProcessors() * 2, 100), 
8)` | No       | 0.2.0         |
+| `gravitino.server.webserver.maxThreads`              | The maximum number of 
threads in the thread pool used by the Jetty webserver. `maxThreads` is 8 if 
the value is less than 8, and `maxThreads` must be great or equal to 
`minThreads`. | `Math.max(Runtime.getRuntime().availableProcessors() * 4, 400)` 
             | No       | 0.1.0         |
+| `gravitino.server.webserver.threadPoolWorkQueueSize` | The size of the queue 
in the thread pool used by the Jetty webserver.                                 
                                                                                
| `100`                                                                        
| No       | 0.1.0         |
+| `gravitino.server.webserver.stopTimeout`             | Time in milliseconds 
to gracefully shut down the Jetty webserver, for more, please see 
`org.eclipse.jetty.server.Server#setStopTimeout`.                               
               | `30000`                                                        
              | No       | 0.2.0         |
+| `gravitino.server.webserver.idleTimeout`             | The timeout in 
milliseconds of idle connections.                                               
                                                                                
       | `30000`                                                                
      | No       | 0.2.0         |
+| `gravitino.server.webserver.requestHeaderSize`       | Maximum size of HTTP 
requests.                                                                       
                                                                                
 | `131072`                                                                     
| No       | 0.1.0         |
+| `gravitino.server.webserver.responseHeaderSize`      | Maximum size of HTTP 
responses.                                                                      
                                                                                
 | `131072`                                                                     
| No       | 0.1.0         |
+| `gravitino.server.shutdown.timeout`                  | Time in milliseconds 
to gracefully shut down of the Gravitino webserver.                             
                                                                                
 | `3000`                                                                       
| No       | 0.2.0         |
+| `gravitino.server.webserver.customFilters`           | Comma-separated list 
of filter class names to apply to the API.                                      
                                                                                
 | (none)                                                                       
| No       | 0.4.0         |
+| `gravitino.extension.restApiPackages`                | Comma-separated list 
of REST API packages to expand                                                  
                                                                                
 | (none)                                                                       
| No       | 0.6.0         |

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to