jerryshao commented on code in PR #4250:
URL: https://github.com/apache/gravitino/pull/4250#discussion_r1698347652


##########
docs/iceberg-rest-service.md:
##########
@@ -119,6 +119,24 @@ The `clients` property for example:
 `catalog-impl` has no effect.
 :::
 
+### S3 configuration
+
+Gravitino Iceberg REST service support using static access-key-id and 
secret-access-key to access S3 data.
+
+| Configuration item                            | Description                  
                                                                                
                                                                                
                          | Default value | Required | Since Version |
+|-----------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------|----------|---------------|
+| `gravitino.iceberg-rest.io-impl`              | The io implementation for 
`FileIO` in Iceberg, use `org.apache.iceberg.aws.s3.S3FileIO` for s3.           
                                                                                
                             | (none)        | No       | 0.6.0         |

Review Comment:
   "IO"



##########
docs/iceberg-rest-service.md:
##########
@@ -119,6 +119,24 @@ The `clients` property for example:
 `catalog-impl` has no effect.
 :::
 
+### S3 configuration
+
+Gravitino Iceberg REST service support using static access-key-id and 
secret-access-key to access S3 data.

Review Comment:
   "...supports...."



##########
docs/iceberg-rest-service.md:
##########
@@ -163,7 +181,7 @@ For example, we can configure Spark catalog options to use 
Gravitino Iceberg RES
 --conf spark.sql.catalog.rest.uri=http://127.0.0.1:9001/iceberg/
 ```
 
-You may need to adjust the Iceberg Spark runtime jar file name according to 
the real version number in your environment.
+You may need to adjust the Iceberg Spark runtime jar file name according to 
the real version number in your environment. If you want to access the data 
stored in S3, you should download 
[iceberg-aws-bundle](https://mvnrepository.com/artifact/org.apache.iceberg/iceberg-aws-bundle).
 

Review Comment:
   Can you please provide an example here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to