jerryshao commented on code in PR #3933: URL: https://github.com/apache/gravitino/pull/3933#discussion_r1699362315
########## spark-connector/spark-common/src/test/java/org/apache/gravitino/spark/connector/integration/test/sql/SparkTestConfig.java: ########## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.spark.connector.integration.test.sql; + +import java.nio.file.Paths; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.List; +import org.apache.gravitino.Config; +import org.apache.gravitino.config.ConfigBuilder; +import org.apache.gravitino.config.ConfigEntry; +import org.junit.platform.commons.util.StringUtils; + +public class SparkTestConfig extends Config { + private static final String DEFAULT_BASE_DIR = + Paths.get( + System.getenv("GRAVITINO_ROOT_DIR"), + "spark-connector", + "spark-common", + "src", + "test", + "resources") + .toString(); + + private static final ConfigEntry<String> TEST_BASE_DIR = + new ConfigBuilder("gravitino.test.sql.dir") + .doc("The Spark SQL test base dir") + .version("0.6.0") + .stringConf() + .createWithDefault(DEFAULT_BASE_DIR); + + private static final ConfigEntry<String> TEST_SQLS = + new ConfigBuilder("gravitino.test.sqls") + .doc( + "Specify the test SQLs, using directory to specify group of SQLs like `test-sqls/hive`, using file path to specify one SQL like `test-sqls/hive/basic.sql`, use `,` to split multi part") + .version("0.6.0") + .stringConf() + .create(); + + private static final ConfigEntry<Boolean> GENERATE_GOLDEN_FILES = + new ConfigBuilder("gravitino.test.generate.golden.files") + .doc( + "Whether generate golden files which are used to check the correctness of the SQL result") + .version("0.6.0") + .booleanConf() + .createWithDefault(Boolean.FALSE); + + private static final ConfigEntry<String> GRAVITINO_METALAKE_NAME = + new ConfigBuilder("gravitino.test.gravitino.metalake") + .doc("The metalake name to run the test") + .version("0.6.0") + .stringConf() + .createWithDefault("test"); + + private static final ConfigEntry<Boolean> SETUP_GRAVITINO_ENV = + new ConfigBuilder("gravitino.test.setup.env") + .doc("Whether to setup Gravitino and hive environment") + .version("0.6.0") + .booleanConf() + .createWithDefault(Boolean.FALSE); + + private static final ConfigEntry<String> GRAVITINO_URI = + new ConfigBuilder("gravitino.test.gravitino.uri") + .doc("Gravitino uri address, only available when `gravitino.test.setup.env` is false") + .version("0.6.0") + .stringConf() + .createWithDefault("http://127.0.0.1:8090";); + + private static final ConfigEntry<String> WAREHOUSE_DIR = + new ConfigBuilder("gravitino.test.gravitino.warehouse") + .doc("The warehouse location, only available when `gravitino.test.setup.env` is false") + .version("0.6.0") + .stringConf() + .createWithDefault("hdfs://127.0.0.1:9000/user/hive/warehouse-spark-test"); + + public String getBaseDir() { + return get(TEST_BASE_DIR); + } + + public boolean generateGoldenFiles() { + return get(GENERATE_GOLDEN_FILES); + } + + public boolean isSetupGravitinoEnv() { + return get(SETUP_GRAVITINO_ENV); + } + + public List<String> getTestSQLs() { + String testSQLs = get(TEST_SQLS); + if (StringUtils.isNotBlank(testSQLs)) { + return Arrays.asList(testSQLs.split("\\s*,\\s*")); + } + return new ArrayList<>(); + } + + public String getGravitinoUri() { + return get(GRAVITINO_URI); + } + + public String getMetalakeName() { + return get(GRAVITINO_METALAKE_NAME); + } + + public String getWarehouseLocation() { + return get(WAREHOUSE_DIR); + } +} Review Comment: If you want to keep this configuration, you should have a better name to clarify its scope and usage, currently I feel the name is randomly picked, some of them are not so meaningful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
