jerryshao commented on code in PR #4262:
URL: https://github.com/apache/gravitino/pull/4262#discussion_r1701216422
##########
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/authentication/kerberos/KerberosConfig.java:
##########
@@ -95,12 +95,18 @@ public int getFetchTimeoutSec() {
new ImmutableMap.Builder<String, PropertyEntry<?>>()
.put(
KEY_TAB_URI_KEY,
- PropertyEntry.stringImmutablePropertyEntry(
- KEY_TAB_URI_KEY, "The uri of key tab for the catalog",
false, null, false, false))
+ PropertyEntry.stringPropertyEntry(
+ KEY_TAB_URI_KEY,
+ "The uri of key tab for the catalog",
+ false,
Review Comment:
I found that you just changed some of the parameters, not all. It would be
better to change all the boolean values. Also, don't need to explain, just `/*
<parameter_name> */` is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
