yuqi1129 commented on code in PR #4262:
URL: https://github.com/apache/gravitino/pull/4262#discussion_r1701333653
##########
catalogs/catalog-hive/src/main/java/org/apache/gravitino/catalog/hive/HiveCatalogPropertiesMeta.java:
##########
@@ -59,60 +59,68 @@ public class HiveCatalogPropertiesMeta extends
BaseCatalogPropertiesMetadata {
.put(
METASTORE_URIS,
PropertyEntry.stringRequiredPropertyEntry(
- METASTORE_URIS, "The Hive metastore URIs", true, false))
+ METASTORE_URIS, "The Hive metastore URIs", false, false))
.put(
CLIENT_POOL_SIZE,
PropertyEntry.integerOptionalPropertyEntry(
CLIENT_POOL_SIZE,
"The maximum number of Hive metastore clients in the pool
for Gravitino",
- true,
+ false /* Whether this property is immutable */,
DEFAULT_CLIENT_POOL_SIZE,
false))
.put(
CLIENT_POOL_CACHE_EVICTION_INTERVAL_MS,
PropertyEntry.longOptionalPropertyEntry(
CLIENT_POOL_CACHE_EVICTION_INTERVAL_MS,
"The cache pool eviction interval",
- true,
+ false /* Whether this property is immutable */,
DEFAULT_CLIENT_POOL_CACHE_EVICTION_INTERVAL_MS,
false))
.put(
IMPERSONATION_ENABLE,
PropertyEntry.booleanPropertyEntry(
IMPERSONATION_ENABLE,
"Enable user impersonation for Hive catalog",
- false,
- true,
+ false /* Whether this property is required */,
+ true /* Whether this property is immutable */,
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
