FANNG1 commented on code in PR #4262:
URL: https://github.com/apache/gravitino/pull/4262#discussion_r1701798098
##########
catalogs/catalog-lakehouse-iceberg/src/main/java/org/apache/gravitino/catalog/lakehouse/iceberg/IcebergCatalogPropertiesMetadata.java:
##########
@@ -65,24 +65,36 @@ public class IcebergCatalogPropertiesMetadata extends
BaseCatalogPropertiesMetad
enumImmutablePropertyEntry(
CATALOG_BACKEND,
"Iceberg catalog type choose properties",
- true,
+ true /* required */,
IcebergCatalogBackend.class,
- null,
- false,
- false),
- stringRequiredPropertyEntry(URI, "Iceberg catalog uri config",
false, false),
+ null /* defaultValue */,
+ false /* hidden */,
+ false /* reserved */),
stringRequiredPropertyEntry(
- WAREHOUSE, "Iceberg catalog warehouse config", false, false),
+ URI, "Iceberg catalog uri config", false /* immutable */,
false /* hidden */),
+ stringRequiredPropertyEntry(
+ WAREHOUSE,
+ "Iceberg catalog warehouse config",
+ false /* immutable */,
+ false /* hidden */),
stringOptionalPropertyEntry(
- IcebergConstants.IO_IMPL, "FileIO implement for Iceberg",
true, null, false),
+ IcebergConstants.IO_IMPL,
+ "FileIO implement for Iceberg",
+ true /* immutable */,
Review Comment:
this could be mutable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
