jerqi commented on code in PR #4354: URL: https://github.com/apache/gravitino/pull/4354#discussion_r1704026615
########## server/src/main/java/org/apache/gravitino/server/web/rest/OwnerOperations.java: ########## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.server.web.rest; + +import com.codahale.metrics.annotation.ResponseMetered; +import com.codahale.metrics.annotation.Timed; +import java.util.Locale; +import java.util.Optional; +import javax.servlet.http.HttpServletRequest; +import javax.ws.rs.GET; +import javax.ws.rs.PUT; +import javax.ws.rs.Path; +import javax.ws.rs.PathParam; +import javax.ws.rs.Produces; +import javax.ws.rs.core.Context; +import javax.ws.rs.core.Response; +import org.apache.gravitino.GravitinoEnv; +import org.apache.gravitino.MetadataObject; +import org.apache.gravitino.MetadataObjects; +import org.apache.gravitino.authorization.Owner; +import org.apache.gravitino.authorization.OwnerManager; +import org.apache.gravitino.dto.requests.OwnerSetRequest; +import org.apache.gravitino.dto.responses.OwnerResponse; +import org.apache.gravitino.dto.responses.SetResponse; +import org.apache.gravitino.dto.util.DTOConverters; +import org.apache.gravitino.metrics.MetricNames; +import org.apache.gravitino.server.authorization.NameBindings; +import org.apache.gravitino.server.web.Utils; + [email protected] +@Path("/metalakes/{metalake}/owners") +public class OwnerOperations { + + private final OwnerManager ownerManager; + + @Context private HttpServletRequest httpRequest; + + public OwnerOperations() { + // Because ownerManager may be null when Gravitino doesn't enable authorization, + // and Jersey injection doesn't support null value. So OwnerOperations chooses to retrieve + // ownerManager from GravitinoEnv instead of injection here. + this.ownerManager = GravitinoEnv.getInstance().ownerManager(); + } + + @GET + @Path("{type}/{fullName}") + @Produces("application/vnd.gravitino.v1+json") + @Timed(name = "get-object-owner." + MetricNames.HTTP_PROCESS_DURATION, absolute = true) + @ResponseMetered(name = "get-object-owner", absolute = true) + public Response getOwnerForObject( + @PathParam("metalake") String metalake, + @PathParam("type") String type, + @PathParam("fullName") String fullName) { + try { + MetadataObject object = + MetadataObjects.parse( + fullName, MetadataObject.Type.valueOf(type.toUpperCase(Locale.ROOT))); + return Utils.doAs( + httpRequest, + () -> { + Optional<Owner> owner = ownerManager.getOwner(metalake, object); + if (owner.isPresent()) { + return Utils.ok(new OwnerResponse(DTOConverters.toDTO(owner.get()))); + } else { + return Utils.ok(new OwnerResponse(null)); + } + }); + } catch (Exception e) { + return ExceptionHandlers.handleOwnerException( + OperationType.GET, String.format("metadata object %s", fullName), metalake, e); + } + } + + @PUT + @Path("{type}/{fullName}") + @Produces("application/vnd.gravitino.v1+json") + @Timed(name = "set-object-owner." + MetricNames.HTTP_PROCESS_DURATION, absolute = true) + @ResponseMetered(name = "set-object-owner", absolute = true) + public Response setOwnerForObject( + @PathParam("metalake") String metalake, + @PathParam("type") String type, + @PathParam("fullName") String fullName, + OwnerSetRequest request) { Review Comment: One is the type of owner, the other is the type of metadata object. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
