xloya commented on code in PR #4281: URL: https://github.com/apache/gravitino/pull/4281#discussion_r1706454770
########## api/src/main/java/org/apache/gravitino/file/FilesetDataOperationCtx.java: ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.file; + +import org.apache.gravitino.annotation.Evolving; + +/** + * An interface representing a fileset data operation context. This interface defines some + * information need to report to the server. + * + * <p>{@link FilesetDataOperationCtx} defines the basic properties of a fileset data operation + * context object. + */ +@Evolving +public interface FilesetDataOperationCtx { + /** @return The sub path which is operated by the data operation . */ + String subPath(); + + /** @return The data operation type. */ + FilesetDataOperation operation(); + + /** @return The client type of the data operation. */ + ClientType clientType(); +} Review Comment: @jerryshao I have wrote a document about how to pass audit content when accessing the API. Please check it out when you have time, thanks: https://docs.google.com/document/d/1wnSRSPcppBrJnb5MAL8gWuNNvhSkeXVXCE0r_zcYd1M. In general, from the perspective of open source and commercial product practices, it is more common to put additional audit content in the HTTP Header of the API request. In addition, as far as the API in this PR is concerned, considering that it only needs to be open to the Hadoop / Python GVFS client, we may consider not expose the API in the Java/Python Client, and only Hadoop/Python GVFS itself maintains the logic of calling the API. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
