Re: [PR] [#4266] feat: simplify compilation by compiling scripts [gravitino]

Wed, 07 Aug 2024 10:40:39 -0700 


featherchen commented on PR #4382:
URL: https://github.com/apache/gravitino/pull/4382#issuecomment-2273993591

   > This is cool I think. I tried it on my laptop (Macbook), the display has 
some problem:
   > <img alt="image" width="1129" 
src="https://private-user-images.githubusercontent.com/5411805/355774329-cc6fd61a-656b-49a1-8721-b00af8160d24.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjMwNDc3NTYsIm5iZiI6MTcyMzA0NzQ1NiwicGF0aCI6Ii81NDExODA1LzM1NTc3NDMyOS1jYzZmZDYxYS02NTZiLTQ5YTEtODcyMS1iMDBhZjgxNjBkMjQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MDdUMTYxNzM2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZTBjMjFiM2Q2ODJjZjdjYzIzNWJlOTQ2ODYyZDBmNDE5OWM2NTQ1MjZjMDJhMGE1NGIwYjY3ZjY2ODRjZDNlMCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.lxb9DaCot_kt1mCj4KbHlu4bjAPgoZ_E-rzbraj6vMo";>
   > 
   > Besides, putting it to a sub-folder like "dev" might be better, later we 
can put more such scripts that for developers to it.
   
   @shaofengshi Thanks for the reply, The reason behind the problem might be 
the default bash version of macOS, which is 3.2, does not support `\e` as an 
escape sequence in `echo`. (Ref: 
https://unix.stackexchange.com/questions/730403/echo-e-e-does-not-print-an-escape-from-bash-script-on-macos).
 Therefore, I replace `echo` with `printf`, which should solve this problem and 
give us more flexibility of formatting.
   
   By the way, I marked this PR as draft due to the discussion in #4266 about 
what kind of commend and properties setting (i.e. python and java version) 
should we offer in this script. Do you have any thoughts on it ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to