caican00 commented on code in PR #4403:
URL: https://github.com/apache/gravitino/pull/4403#discussion_r1708391416
##########
.github/workflows/spark-integration-test.yml:
##########
@@ -92,9 +92,13 @@ jobs:
run: |
if [ "${{ matrix.scala-version }}" == "2.12" ];then
./gradlew -PskipTests -PtestMode=${{ matrix.test-mode }}
-PjdkVersion=${{ matrix.java-version }} -PscalaVersion=${{ matrix.scala-version
}} -PskipDockerTests=false :spark-connector:spark-3.3:test --tests
"org.apache.gravitino.spark.connector.integration.test.**"
+ ./gradlew -PskipTests -PtestMode=${{ matrix.test-mode }}
-PjdkVersion=${{ matrix.java-version }} -PscalaVersion=${{ matrix.scala-version
}} -PskipDockerTests=false :spark-connector:spark-3.4:test --tests
"org.apache.gravitino.spark.connector.integration.test.**"
+ ./gradlew -PskipTests -PtestMode=${{ matrix.test-mode }}
-PjdkVersion=${{ matrix.java-version }} -PscalaVersion=${{ matrix.scala-version
}} -PskipDockerTests=false :spark-connector:spark-3.5:test --tests
"org.apache.gravitino.spark.connector.integration.test.**"
+ fi
+ if [ "${{ matrix.scala-version }}" == "2.13" ];then
+ ./gradlew -PtestMode=${{ matrix.test-mode }} -PjdkVersion=${{
matrix.java-version }} -PscalaVersion=${{ matrix.scala-version }}
:spark-connector:spark-3.4:test
Review Comment:
I think we must provide a way to test for compatibility with scala2.13, and
if adding scala2.13 will make the pipelines too slow, we can skip docker tests.
WDYT? @FANNG1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
