xunliu commented on code in PR #4429:
URL: https://github.com/apache/gravitino/pull/4429#discussion_r1709401985
##########
core/src/main/java/org/apache/gravitino/GravitinoEnv.java:
##########
@@ -348,28 +352,30 @@ private void initGravitinoServerComponents() {
// Create and initialize metalake related modules
MetalakeDispatcher metalakeManager = new MetalakeManager(entityStore,
idGenerator);
+ MetalakeHookDispatcher metalakeHookDispatcher = new
MetalakeHookDispatcher(metalakeManager);
MetalakeNormalizeDispatcher metalakeNormalizeDispatcher =
- new
MetalakeNormalizeDispatcher(installDispatcherHooks(metalakeManager));
+ new MetalakeNormalizeDispatcher(metalakeHookDispatcher);
this.metalakeDispatcher = new MetalakeEventDispatcher(eventBus,
metalakeNormalizeDispatcher);
// Create and initialize Catalog related modules
this.catalogManager = new CatalogManager(config, entityStore, idGenerator);
+ CatalogHookDispatcher catalogHookDispatcher = new
CatalogHookDispatcher(catalogManager);
CatalogNormalizeDispatcher catalogNormalizeDispatcher =
- new
CatalogNormalizeDispatcher(installDispatcherHooks((CatalogDispatcher)
catalogManager));
+ new CatalogNormalizeDispatcher(catalogHookDispatcher);
Review Comment:
I also feel the current `Dispatcher` mechanism inelegant.
I create a issue track it
- https://github.com/apache/gravitino/issues/4446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
