jerryshao commented on code in PR #4448:
URL: https://github.com/apache/gravitino/pull/4448#discussion_r1710916044
##########
clients/client-java/src/main/java/org/apache/gravitino/client/GravitinoMetalake.java:
##########
@@ -843,6 +844,20 @@ public GravitinoMetalake build() {
}
}
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+
+ if (!(o instanceof GravitinoMetalake)) {
+ return false;
+ }
+
+ GravitinoMetalake that = (GravitinoMetalake) o;
+ return super.equals(that) && Objects.equal(restClient, that.restClient);
Review Comment:
I feel like that we don't need to compare the `restClient` object. If the
same metalake is gotten from different clients, I think though `restClient` is
different, the `GravitinoMetalake` itself should be the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
