caican00 commented on code in PR #4403:
URL: https://github.com/apache/gravitino/pull/4403#discussion_r1712562946
##########
.github/workflows/build.yml:
##########
@@ -98,6 +98,11 @@ jobs:
- name: Build with Gradle
run: ./gradlew build -PskipITs -PjdkVersion=${{ matrix.java-version }}
-PskipDockerTests=false -x :clients:client-python:build
+ - name: Build spark connector with scala 2.13
Review Comment:
@FANNG1 what I mean is to add it as a new job for the build workflow, like
this:
```
spark-connector-build:
runs-on: ubuntu-latest
strategy:
matrix:
scala-version: [ 2.12, 2.13 ]
timeout-minutes: 30
needs: changes
if: needs.changes.outputs.source_changes == 'true'
steps:
- uses: actions/checkout@v3
- uses: actions/setup-java@v4
with:
java-version: 8
distribution: 'temurin'
cache: 'gradle'
- name: Free up disk space
run: |
dev/ci/util_free_space.sh
- name: Build with Gradle
run: |
if [ "${{ matrix.scala-version }}" == "2.12" ];then
./gradlew -PscalaVersion=${{ matrix.scala-version }}
:spark-connector:spark-3.3:test
fi
./gradlew -PscalaVersion=${{ matrix.scala-version }}
:spark-connector:spark-3.4:test
./gradlew -PscalaVersion=${{ matrix.scala-version }}
:spark-connector:spark-3.5:test
- name: Upload unit tests report
uses: actions/upload-artifact@v3
if: failure()
with:
name: unit test report
path: |
build/reports
spark-connector/**/*.log
```
after the `changes` succeeded, the `spark-connector-build` can be executed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
