Re: [PR] [#4386] Fix(spark-connector): spark connector build failed with scala2.13 [gravitino]

Sun, 11 Aug 2024 23:28:31 -0700 


caican00 commented on code in PR #4403:
URL: https://github.com/apache/gravitino/pull/4403#discussion_r1713220133


##########
.github/workflows/build.yml:
##########
@@ -98,6 +98,11 @@ jobs:
       - name: Build with Gradle
         run: ./gradlew build -PskipITs -PjdkVersion=${{ matrix.java-version }} 
-PskipDockerTests=false -x :clients:client-python:build
 
+      - name: Build spark connector with scala 2.13

Review Comment:
   > > so what's the benefit of using a job not a step?
   > 
   > @FANNG1 It does not affect the job named `build` and they can be built in 
parallel.
   
   
![image](https://github.com/user-attachments/assets/c5ce9ff9-a524-4e67-9ba4-a82d780e023e)
   cc @FANNG1 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to