xiaozcy commented on code in PR #4232:
URL: https://github.com/apache/gravitino/pull/4232#discussion_r1713353076
##########
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/authentication/AuthenticationConfig.java:
##########
@@ -36,7 +36,8 @@ public class AuthenticationConfig extends Config {
enum AuthenticationType {
SIMPLE,
- KERBEROS;
+ KERBEROS,
+ AWS;
Review Comment:
To make it more clear, I think there are two ways to solve this:
- Treat these configurations in S3 as catalog properties simply. In this
way, we don't have to figure out a name for the type of authentication(which
also may not be appropriate). But we may have to add a property like
`storage-type` to specify the actual storage system for Hadoop catalog, because
we cannot do some checks and transforms for these configurations without
knowing this. As more storage systems would be supported in the future, I think
this might be a better way.
- Still add a new authentication type like we already did. In this case, we
have to figure out a name for it. Based on the previous discussion, the
candidates would be `AWS`, `AWS-AKSK`, `S3` or `S3_AKSK`. Although all of these
seems not perfect, I would choose `S3_AKSK` for me, despite of the fact that we
support anonymous access to a publicly accessible S3 bucket.
WDYT? @jerryshao @yuqi1129 @jerqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
