FANNG1 commented on PR #4451:
URL: https://github.com/apache/gravitino/pull/4451#issuecomment-2285129674
There're some residual logic to process DefaultColumnPosition in
`IcebergTableOpsHelper.java`, do you like to remove it in this PR?
```java
private void doUpdateColumnPosition(
UpdateSchema icebergUpdateSchema,
UpdateColumnPosition updateColumnPosition,
Schema icebergTableSchema) {
StructType tableSchema = icebergTableSchema.asStruct();
// not need any more
ColumnPosition columnPosition =
getColumnPositionForIceberg(tableSchema,
updateColumnPosition.getPosition());
doMoveColumn(icebergUpdateSchema, updateColumnPosition.fieldName(),
columnPosition);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
