mchades commented on code in PR #4497:
URL: https://github.com/apache/gravitino/pull/4497#discussion_r1716238539
##########
integration-test/src/test/resources/trino-ci-testset/testsets/jdbc-mysql/00008_alter_catalog.txt:
##########
@@ -1,17 +1,17 @@
CALL
-"gt_mysql_xxx1","jdbc-mysql","{""jdbc-url"":""jdbc:mysql://%/?useSSL=false"",""jdbc-user"":""trino"",""jdbc-password"":""ds123"",""jdbc-driver"":""com.mysql.cj.jdbc.Driver""}"
+"gt_mysql_xxx1","jdbc-mysql","{""jdbc-driver"":""com.mysql.cj.jdbc.Driver"",""jdbc-password"":""ds123"",""jdbc-url"":""jdbc:mysql://%/?useSSL=false"",""jdbc-user"":""trino""}"
Review Comment:
Does it have to be in order? Or just for better readability?
##########
integration-test/trino-distribution-it/docker-compose.yaml:
##########
Review Comment:
I suggest refactoring the origin `trino-it` to the `trino-distribution-it`
instead of introducing a new test. Furthermore, you can also move it to the
`trino-connector` module and setup a new CI workflow for TrinoIT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
