jerryshao commented on code in PR #4501:
URL: https://github.com/apache/gravitino/pull/4501#discussion_r1716889588


##########
clients/client-java/src/main/java/org/apache/gravitino/client/GravitinoClient.java:
##########
@@ -242,6 +242,7 @@ public boolean deleteRole(String role) throws 
NoSuchMetalakeException {
    * @return The created Role instance.
    * @throws RoleAlreadyExistsException If a Role with the same name already 
exists.
    * @throws NoSuchMetalakeException If the Metalake with the given name does 
not exist.
+   * @throws NoSuchMetadataObjectException If securable object doesn't exist
    * @throws RuntimeException If creating the Role encounters storage issues.
    */
   public Role createRole(

Review Comment:
   Should you also add this exception to the interface signature?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to