mchades commented on code in PR #4497:
URL: https://github.com/apache/gravitino/pull/4497#discussion_r1717828662
##########
trino-connector/src/main/java/org/apache/gravitino/trino/connector/system/table/GravitinoSystemTableCatalog.java:
##########
@@ -56,21 +60,34 @@ public GravitinoSystemTableCatalog(CatalogConnectorManager
catalogConnectorManag
@Override
public Page loadPageData() {
- List<GravitinoCatalog> catalogs = catalogConnectorManager.getCatalogs();
- int size = catalogs.size();
+ List<GravitinoCatalog> gravitinoCatalogs = new ArrayList<>();
+ catalogConnectorManager
Review Comment:
plz add comment to explain why can not call
`catalogConnectorManager.getCatalogs()` directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
