Naresh-kumar-Thodupunoori commented on PR #4511: URL: https://github.com/apache/gravitino/pull/4511#issuecomment-2290812380
Ok, and would like me to change anything else!? On Thu, 15 Aug, 2024, 12:56 pm Jerry Shao, ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In > catalogs/catalog-hive/src/test/java/org/apache/gravitino/catalog/hive/TestFetchFileUtils.java > <https://github.com/apache/gravitino/pull/4511#discussion_r1718063564>: > > > - Assertions.assertTrue(destFile.exists()); > + String fileUrl = "https://downloads.apache.org/hadoop/common/KEYS";; > + Configuration conf = new Configuration(); > + > + boolean success = false; > + int attempts = 0; > + > + while (!success && attempts < MAX_RETRIES) { > + try { > + FetchFileUtils.fetchFileFromUri(fileUrl, destFile, 10, conf); > + success = true; > + } catch (IOException e) { > + attempts++; > + if (attempts < MAX_RETRIES) { > + System.out.println( > + "Attempt " + attempts + " failed. Retrying in " + RETRY_DELAY_MS + "ms."); > > We don't allow to use println, please use log4j or remove this line. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/gravitino/pull/4511#pullrequestreview-2239866024>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/BBTIQ2UCZ4RZVWMTOKSP4CTZRRJZBAVCNFSM6AAAAABMPYKCMCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMZZHA3DMMBSGQ> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
