mchades commented on code in PR #4523:
URL: https://github.com/apache/gravitino/pull/4523#discussion_r1718212402
##########
integration-test/trino-it/docker-compose.yaml:
##########
@@ -20,7 +20,7 @@
services:
hive:
- image: datastrato/gravitino-ci-hive:0.1.13
+ image: datastrato/gravitino-ci:hive-0.1.13
Review Comment:
datastrato -> apache?
##########
catalogs/catalog-jdbc-doris/build.gradle.kts:
##########
@@ -85,15 +85,11 @@ tasks {
tasks.test {
val skipUTs = project.hasProperty("skipTests")
- doFirst {
- environment("GRAVITINO_CI_DORIS_DOCKER_IMAGE",
"datastrato/gravitino-ci-doris:0.1.5")
- }
-
if (skipUTs) {
// Only run integration tests
include("**/integration/**")
}
-
+ environment("GRAVITINO_CI_DORIS_DOCKER_IMAGE",
"apache/gravitino-ci:doris-0.1.5")
Review Comment:
If so, I suggest declaring all variables in root kts in advance, regardless
of whether it is integration testing, then we can remove this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
