mygrsun commented on code in PR #4469:
URL: https://github.com/apache/gravitino/pull/4469#discussion_r1721161136
##########
catalogs/catalog-hive/src/main/java/org/apache/gravitino/catalog/hive/HiveCatalogOperations.java:
##########
@@ -557,23 +556,18 @@ public NameIdentifier[] listTables(Namespace namespace)
throws NoSuchSchemaExcep
// then based on
// those names we can obtain metadata for each individual table and get
the type we needed.
List<String> allTables = clientPool.run(c ->
c.getAllTables(schemaIdent.name()));
- return clientPool.run(
- c ->
- c.getTableObjectsByName(schemaIdent.name(), allTables).stream()
- .filter(
- tb -> {
- boolean isSupportTable =
SUPPORT_TABLE_TYPES.contains(tb.getTableType());
- if (!isSupportTable) {
- return false;
- }
- if (!listAllTables) {
- Map<String, String> parameters = tb.getParameters();
- return isHiveTable(parameters);
- }
- return true;
- })
- .map(tb -> NameIdentifier.of(namespace, tb.getTableName()))
- .toArray(NameIdentifier[]::new));
+ if (!listAllTables) {
+ String filter =
+ String.format(
+ "%stable_type = \"ICEBERG\"",
hive_metastoreConstants.HIVE_FILTER_FIELD_PARAMS);
Review Comment:
I add some comment ,please review again
##########
catalogs/catalog-hive/src/main/java/org/apache/gravitino/catalog/hive/HiveCatalogOperations.java:
##########
@@ -557,23 +556,18 @@ public NameIdentifier[] listTables(Namespace namespace)
throws NoSuchSchemaExcep
// then based on
// those names we can obtain metadata for each individual table and get
the type we needed.
List<String> allTables = clientPool.run(c ->
c.getAllTables(schemaIdent.name()));
- return clientPool.run(
- c ->
- c.getTableObjectsByName(schemaIdent.name(), allTables).stream()
- .filter(
- tb -> {
- boolean isSupportTable =
SUPPORT_TABLE_TYPES.contains(tb.getTableType());
- if (!isSupportTable) {
- return false;
- }
- if (!listAllTables) {
- Map<String, String> parameters = tb.getParameters();
- return isHiveTable(parameters);
- }
- return true;
- })
- .map(tb -> NameIdentifier.of(namespace, tb.getTableName()))
- .toArray(NameIdentifier[]::new));
+ if (!listAllTables) {
+ String filter =
+ String.format(
+ "%stable_type = \"ICEBERG\"",
hive_metastoreConstants.HIVE_FILTER_FIELD_PARAMS);
Review Comment:
I add some comments ,please review again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
