jerqi commented on PR #4515: URL: https://github.com/apache/gravitino/pull/4515#issuecomment-2301655274
Thanks for your hard work! The code seems good shape. There are some points to discuss with you. 1. Could you configure the catalog with other authorization plugin instead of RangerPlugin? 2. Some privileges like `use schema`, `use catalog`, `create catalog` could be pushed down underlying system, too. The check logic will throw exception for them. 3. We should reduce the duplicated code further as possible as we can. 4. If we use a label for Gravitino, but we don't have any catalog information. If we have two hive catalogs, catalog1 and catalog2, they have the same name schema schema1, will the policies influence each other? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
