LiuQhahah commented on code in PR #4600:
URL: https://github.com/apache/gravitino/pull/4600#discussion_r1725173764
##########
catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/config/JdbcConfig.java:
##########
@@ -33,7 +34,7 @@ public class JdbcConfig extends Config {
.doc("The url of the Jdbc connection")
.version(ConfigConstants.VERSION_0_3_0)
.stringConf()
- .checkValue(StringUtils::isNotBlank,
ConfigConstants.NOT_BLANK_ERROR_MSG)
+ .checkValue(TypeValid::isJdbcURL,
ConfigConstants.JDBC_URL_INVALID_ERROR_MSG)
Review Comment:
Hi @yuqi1129
I have added the uri check for IceBerg catalog and
"gravitino.entity.store.relational.jdbcUrl"
Thanks
Qiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
