xloya commented on code in PR #4592:
URL: https://github.com/apache/gravitino/pull/4592#discussion_r1728214117
##########
clients/client-python/gravitino/filesystem/gvfs.py:
##########
@@ -500,6 +501,12 @@ def _convert_actual_path(self, path, context:
FilesetContext):
f"Path {path} does not start with valid prefix
{actual_prefix}."
)
virtual_location =
self._get_virtual_location(context.get_name_identifier())
+ # if the storage location is end with "/",
+ # we should truncate this to avoid replace issues.
+ if actual_prefix.endswith(self.SLASH) and not
virtual_location.endswith(
Review Comment:
Virtual location which concated in the method of `_get_virtual_location`
will not have the tailing slash, so we only need check the `actual_prefix`
which actually is the storage location.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
