mchades commented on code in PR #4808: URL: https://github.com/apache/gravitino/pull/4808#discussion_r1738268242
########## docs/lakehouse-iceberg-catalog.md: ########## @@ -264,24 +264,24 @@ You can pass [Iceberg table properties](https://iceberg.apache.org/docs/1.5.2/co The Gravitino server doesn't allow passing the following reserved fields. -| Configuration item | Description | -|---------------------------------|---------------------------------------------------------| -| `comment` | The table comment. | -| `creator` | The table creator. | -| `current-snapshot-id` | The snapshot represents the current state of the table. | -| `cherry-pick-snapshot-id` | Selecting a specific snapshot in a merge operation. | -| `sort-order` | Selecting a specific snapshot in a merge operation. | -| `identifier-fields` | The identifier fields for defining the table. | -| `write.distribution-mode` | Defines distribution of write data | +| Configuration item | Description | Default value | Required | Since Version | +|---------------------------|---------------------------------------------------------|---------------|----------|---------------| +| `comment` | The table comment. | None | No | 0.2.0 | +| `creator` | The table creator. | None | No | 0.2.0 | +| `current-snapshot-id` | The snapshot represents the current state of the table. | None | No | 0.2.0 | +| `cherry-pick-snapshot-id` | Selecting a specific snapshot in a merge operation. | None | No | 0.2.0 | +| `sort-order` | Selecting a specific snapshot in a merge operation. | None | No | 0.2.0 | +| `identifier-fields` | The identifier fields for defining the table. | None | No | 0.2.0 | +| `write.distribution-mode` | Defines distribution of write data | None | No | 0.2.0 | Gravitino server doesn't allow to change such properties: -| Configuration item | Description | -|--------------------|----------------------------------------------| -| `location` | Iceberg location for table storage. | -| `format` | Iceberg table format like `iceberg/parquet`. | -| `format-version` | Iceberg meta data format version. | -| `provider` | Table provider like `iceberg`. | +| Configuration item | Description | Default value | Required | Since Version | +|--------------------|----------------------------------------------|---------------|----------|---------------| +| `location` | Iceberg location for table storage. | None | No | 0.2.0 | +| `format` | Iceberg table format like `iceberg/parquet`. | None | No | 0.2.0 | +| `format-version` | Iceberg meta data format version. | None | No | 0.2.0 | +| `provider` | Table provider like `iceberg`. | None | No | 0.2.0 | Review Comment: Since users can pass all the properties provided by Iceberg officials, what is the difference between these properties and official properties? Does the description seem too simple? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
