jerryshao commented on code in PR #4597:
URL: https://github.com/apache/gravitino/pull/4597#discussion_r1739182064
##########
gradle/libs.versions.toml:
##########
@@ -149,6 +149,7 @@ commons-io = { group = "commons-io", name = "commons-io",
version.ref = "commons
caffeine = { group = "com.github.ben-manes.caffeine", name = "caffeine",
version.ref = "caffeine" }
rocksdbjni = { group = "org.rocksdb", name = "rocksdbjni", version.ref =
"rocksdbjni" }
commons-collections4 = { group = "org.apache.commons", name =
"commons-collections4", version.ref = "commons-collections4" }
+iceberg-aliyun = { group = "org.apache.iceberg", name = "iceberg-aliyun",
version.ref = "iceberg" }
Review Comment:
No, you will ship Gravitino with "iceberg-aliyun" dependency, so you need to
add it to the license.bin. The aliyun dependencies you mentioned are manually
added by users, so we don't have to add them to the license.bin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
