FANNG1 commented on code in PR #4808: URL: https://github.com/apache/gravitino/pull/4808#discussion_r1743180563
########## docs/lakehouse-iceberg-catalog.md: ########## @@ -264,16 +264,21 @@ You can pass [Iceberg table properties](https://iceberg.apache.org/docs/1.5.2/co The Gravitino server doesn't allow passing the following reserved fields. -| Configuration item | Description | -|---------------------------------|---------------------------------------------------------| -| `comment` | The table comment. | -| `creator` | The table creator. | -| `location` | Iceberg location for table storage. | -| `current-snapshot-id` | The snapshot represents the current state of the table. | -| `cherry-pick-snapshot-id` | Selecting a specific snapshot in a merge operation. | -| `sort-order` | Selecting a specific snapshot in a merge operation. | -| `identifier-fields` | The identifier fields for defining the table. | -| `write.distribution-mode` | Defines distribution of write data | +| Configuration item | Description | Default value | Required | Since Version | +|---------------------------|--------------------------------------------------------------------------------------|---------------|----------|---------------| +| `comment` | The table comment, please use `comment` field in table meta instead. | None | No | 0.2.0 | +| `creator` | The table creator. | None | No | 0.2.0 | +| `current-snapshot-id` | The snapshot represents the current state of the table. | None | No | 0.2.0 | +| `cherry-pick-snapshot-id` | Selecting a specific snapshot in a merge operation. | None | No | 0.2.0 | +| `sort-order` | Iceberg table sort order, please use `SortOrder` in table meta instead. | None | No | 0.2.0 | +| `identifier-fields` | The identifier fields for defining the table. | None | No | 0.2.0 | +| `write.distribution-mode` | Defines distribution of write data, please use `distribution` in table meta instead. | None | No | 0.2.0 | Review Comment: I removed `default value` and `required` column from the table, since this's seems not so useful for reserved properties. cc @mchades -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
