jerryshao commented on code in PR #4858:
URL: https://github.com/apache/gravitino/pull/4858#discussion_r1745911978
##########
clients/client-java/src/main/java/org/apache/gravitino/client/FilesetCatalog.java:
##########
@@ -238,7 +241,22 @@ public boolean dropFileset(NameIdentifier ident) {
@Override
public String getFileLocation(NameIdentifier ident, String subPath)
throws NoSuchFilesetException {
- throw new UnsupportedOperationException("Not implemented");
+ checkFilesetNameIdentifier(ident);
+ Namespace fullNamespace = getFilesetFullNamespace(ident.namespace());
+
+ CallerContext callerContext = CallerContext.CallerContextHolder.get();
+ Map<String, String> queryParams = Maps.newHashMap();
+ queryParams.put("subPath", subPath);
Review Comment:
I think maybe we should encoding the subPath to avoid supported chars in the
URL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
