yuqi1129 commented on code in PR #4611:
URL: https://github.com/apache/gravitino/pull/4611#discussion_r1747600341
##########
core/src/main/java/org/apache/gravitino/storage/relational/mapper/CatalogMetaSQLProviderFactory.java:
##########
@@ -49,6 +52,88 @@ static class CatalogMetaMySQLProvider extends
CatalogMetaBaseSQLProvider {}
static class CatalogMetaH2Provider extends CatalogMetaBaseSQLProvider {}
+ static class CatalogMetaPostgreSQLProvider extends
CatalogMetaBaseSQLProvider {
Review Comment:
> Can we have a package "postgresql" under this and move all the pg class to
that folder.
Okay.
> Besides, we have several changes for PG, but we don't have UTs to cover
the pg support, only have IT. I think it is not enough, we should add UTs for
PG, as well as for MySQL.
Yeah, I will try to boost a separate PR to test the MySQL and PG backend in
UT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
