FANNG1 commented on code in PR #4893: URL: https://github.com/apache/gravitino/pull/4893#discussion_r1751387253
########## trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/iceberg/IcebergDataTypeTransformer.java: ########## @@ -20,6 +20,9 @@ package org.apache.gravitino.trino.connector.catalog.iceberg; import io.trino.spi.TrinoException; +import io.trino.spi.type.TimeType; +import io.trino.spi.type.TimestampType; +import io.trino.spi.type.TimestampWithTimeZoneType; import io.trino.spi.type.VarbinaryType; import io.trino.spi.type.VarcharType; import org.apache.gravitino.rel.types.Type; Review Comment: seems you shoud add corresponding logic to convert MICROS time to Iceberg time, and forbidden other time precision. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
