yuqi1129 commented on code in PR #4898:
URL: https://github.com/apache/gravitino/pull/4898#discussion_r1752997625


##########
core/src/test/java/org/apache/gravitino/storage/TestEntityStorage.java:
##########
@@ -151,14 +183,16 @@ private void destroy(String type) {
       } catch (Exception e) {
         // Ignore
       }
-    } else if (type.equals(Configs.RELATIONAL_ENTITY_STORE)) {
+    } else if (type.equalsIgnoreCase("h2") || type.equalsIgnoreCase("mysql")) {
       dropAllTables();
       File dir = new File(DB_DIR);
       if (dir.exists()) {
         dir.delete();
       }
 
       FileUtils.deleteQuietly(new File(H2_FILE));
+    } else if (type.equalsIgnoreCase("postgresql")) {
+      // Do nothing

Review Comment:
   PG has the concept database and schema, and each catalog uses a different 
database name. For PostgreSQL catalog:
   
   The database in PosgreSQL is equivalent to the Gravitino catalog, and the 
schema is equivalent to the Gravitino  database.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to