yuqi1129 commented on code in PR #4827:
URL: https://github.com/apache/gravitino/pull/4827#discussion_r1753012656
##########
.github/workflows/access-control-integration-test.yml:
##########
@@ -83,7 +87,8 @@ jobs:
- name: Authorization Integration Test (JDK${{ matrix.java-version
}}-${{ matrix.test-mode }}-${{ matrix.backend }})
id: integrationTest
run: |
- ./gradlew -PskipTests -PtestMode=${{ matrix.test-mode }}
-PjdbcBackend=${{ matrix.backend }} -PjdkVersion=${{ matrix.java-version }}
-PskipDockerTests=false :authorizations:authorization-ranger:test --tests
"org.apache.gravitino.authorization.ranger.integration.test.**"
+ ./gradlew -PskipTests -PtestMode=embedded -PjdbcBackend=h2
-PjdkVersion=${{ matrix.java-version }} -PskipDockerTests=false
:authorizations:authorization-ranger:test --tests
"org.apache.gravitino.authorization.ranger.integration.test.**"
+ ./gradlew -PskipTests -PtestMode=deploy -PjdbcBackend=mysql
-PjdkVersion=${{ matrix.java-version }} -PskipDockerTests=false
:authorizations:authorization-ranger:test --tests
"org.apache.gravitino.authorization.ranger.integration.test.**"
Review Comment:
@mchades
I think you can add a matrix parameter about `jdbcBackend` to reduce
repeated line L92.
##########
.github/workflows/access-control-integration-test.yml:
##########
@@ -22,21 +22,32 @@ jobs:
with:
filters: |
source_changes:
+ - .github/**
- api/**
- authorizations/**
+ - bin/**
Review Comment:
Why do we need to `bin/**` here? for any changes under folder `bin`, I think
`backend test` can cover it.
##########
.github/workflows/spark-integration-test.yml:
##########
@@ -108,3 +107,64 @@ jobs:
spark-connector/v3.5/spark/build/spark-3.5-integration-test.log
distribution/package/logs/*.out
distribution/package/logs/*.log
+
+ SparkIT-on-pr:
+ needs: changes
+ if: (github.event_name == 'pull_request' &&
needs.changes.outputs.source_changes == 'true')
Review Comment:
> Is there any way to reuse the code? duplicated code are hard to maintance.
+1. The current situation seems quite complicated to me and may introduce
excessive time to maintain so many CI trigger condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
