FANNG1 commented on code in PR #4897:
URL: https://github.com/apache/gravitino/pull/4897#discussion_r1757868094
##########
catalogs/catalog-common/src/main/java/org/apache/gravitino/catalog/lakehouse/iceberg/IcebergConstants.java:
##########
@@ -37,20 +37,13 @@ public class IcebergConstants {
// IO properties
public static final String IO_IMPL = "io-impl";
- public static final String GRAVITINO_S3_ENDPOINT = "s3-endpoint";
public static final String ICEBERG_S3_ENDPOINT = "s3.endpoint";
- public static final String GRAVITINO_S3_ACCESS_KEY_ID = "s3-access-key-id";
public static final String ICEBERG_S3_ACCESS_KEY_ID = "s3.access-key-id";
- public static final String GRAVITINO_S3_SECRET_ACCESS_KEY =
"s3-secret-access-key";
public static final String ICEBERG_S3_SECRET_ACCESS_KEY =
"s3.secret-access-key";
- public static final String GRAVITINO_S3_REGION = "s3-region";
public static final String AWS_S3_REGION = "client.region";
- public static final String GRAVITINO_OSS_ENDPOINT = "oss-endpoint";
public static final String ICEBERG_OSS_ENDPOINT = "oss.endpoint";
- public static final String GRAVITINO_OSS_ACCESS_KEY_ID = "oss-access-key-id";
public static final String ICEBERG_OSS_ACCESS_KEY_ID =
"client.access-key-id";
- public static final String GRAVITINO_OSS_ACCESS_KEY_SECRET =
"oss-access-key-secret";
public static final String ICEBERG_OSS_ACCESS_KEY_SECRET =
"client.access-key-secret";
Review Comment:
no, because GCS need to create credential according to a credential file,
For Iceberg, it could only load credential file by setting ENV vars explicitly
or load from GCS instance implicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
