FANNG1 commented on code in PR #4548:
URL: https://github.com/apache/gravitino/pull/4548#discussion_r1757888485
##########
iceberg/iceberg-common/build.gradle.kts:
##########
@@ -83,6 +105,7 @@ dependencies {
annotationProcessor(libs.lombok)
compileOnly(libs.lombok)
+ testImplementation(project(":server-common"))
Review Comment:
because IcebergConfig overwites the default `HTTP port`, we add a test to
check whether it works in `JettyServerConfig`, like:
```java
public void testIcebergHttpPort() {
Map<String, String> properties = ImmutableMap.of();
IcebergConfig icebergConfig = new IcebergConfig(properties);
JettyServerConfig jettyServerConfig =
JettyServerConfig.fromConfig(icebergConfig);
Assertions.assertEquals(
JettyServerConfig.DEFAULT_ICEBERG_REST_SERVICE_HTTP_PORT,
jettyServerConfig.getHttpPort());
Assertions.assertEquals(
JettyServerConfig.DEFAULT_ICEBERG_REST_SERVICE_HTTPS_PORT,
jettyServerConfig.getHttpsPort());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
