jerryshao commented on code in PR #4939: URL: https://github.com/apache/gravitino/pull/4939#discussion_r1764675576
########## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/filesystem/FileSystemType.java: ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.catalog.lakehouse.paimon.filesystem; + +public enum FileSystemType { + LOCAL_FILE, + HDFS, + S3, + OSS; + + public static FileSystemType fromString(String type) { + for (FileSystemType fileSystemType : FileSystemType.values()) { + if (fileSystemType.name().equalsIgnoreCase(type)) { + return fileSystemType; + } + } + + throw new IllegalArgumentException("Unsupported file system type: " + type); + } + + public static FileSystemType fromStoragePath(String storagePath) { Review Comment: I would suggest to leverage the configurations defined by @FANNG1 for Iceberg in Paimon too, we can unify the cloud storage configuration for different catalogs. For other configurations that Gravitino cannot support, we can use "gravitino.bypass". But for some important configurations we should have a unified manner in Gravitino. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
