jerryshao commented on code in PR #4744: URL: https://github.com/apache/gravitino/pull/4744#discussion_r1764693498
########## authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerPrivilegesMappingProvider.java: ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.authorization.ranger; + +/** + * Ranger authorization use this provider to mapping Gravitino privilege to the Ranger privileges. + * We can use this it to support the different Ranger authorization components, such as Hive, HDFS, + * HBase, etc. + */ +public interface RangerPrivilegesMappingProvider { + /** Set the mapping Gravitino privilege name to the Ranger privileges rule. */ + void privilegesMappingRule(); + + /** Set the owner privileges rule. */ + void ownerMappingRule(); + + /** Set the policy resource defines rule. */ + void policyResourceDefinesRule(); Review Comment: I still think that you should have the return value for the method you defined here. Otherwise, it is hard for others to implement a such interface. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
