lilyzhoupeijie commented on code in PR #56:
URL: 
https://github.com/apache/gravitino-playground/pull/56#discussion_r1766256149


##########
init/gravitino/init.sh:
##########
@@ -25,6 +25,10 @@ cp 
/root/gravitino/catalogs/jdbc-mysql/libs/mysql-connector-java-8.0.27.jar /roo
 cp /root/gravitino/catalogs/jdbc-postgresql/libs/postgresql-42.7.0.jar 
/root/gravitino/iceberg-rest-server/libs
 cp /root/gravitino/catalogs/jdbc-mysql/libs/mysql-connector-java-8.0.27.jar 
/root/gravitino/iceberg-rest-server/libs
 cp /tmp/gravitino/gravitino.conf /root/gravitino/conf
+
+# set env var 
+sed -i 's/__MYSQL_HOST_IP__/'"$MYSQL_HOST_IP"'/g' 
/root/gravitino/conf/gravitino.conf
+sed -i 's/__HIVE_HOST_IP__/'"$HIVE_HOST_IP"'/g' 
/root/gravitino/conf/gravitino.conf

Review Comment:
   Normally, the configuration file gravitino.conf should be extracted as a 
configMap for frequent modifications.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to