jerryshao commented on code in PR #4055:
URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768262255
##########
core/src/main/java/org/apache/gravitino/EntityStore.java:
##########
@@ -55,15 +55,19 @@ public interface EntityStore extends Closeable {
* <p>Note. Depends on the isolation levels provided by the underlying
storage, the returned list
* may not be consistent.
*
- * @param namespace the namespace of the entities
* @param <E> class of the entity
+ * @param namespace the namespace of the entities
* @param type the detailed type of the entity
* @param entityType the general type of the entity
- * @throws IOException if the list operation fails
+ * @param allowMissingFields Some fields may have a relatively high
acquisition cost, EntityStore
+ * provide an optional setting to avoid fetching these high-cost fields
to improve the
+ * performance.
* @return the list of entities
+ * @throws IOException if the list operation fails
*/
<E extends Entity & HasIdentifier> List<E> list(
- Namespace namespace, Class<E> type, EntityType entityType) throws
IOException;
+ Namespace namespace, Class<E> type, EntityType entityType, List<Field>
allowMissingFields)
+ throws IOException;
Review Comment:
Maybe we can add a another inteface with default to fetch all the fields,
then you don't have to change the code above for different catalogs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
