jerqi commented on code in PR #4055:
URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768487238
##########
core/src/main/java/org/apache/gravitino/storage/relational/service/UserMetaService.java:
##########
@@ -246,6 +249,38 @@ public <E extends Entity & HasIdentifier> UserEntity
updateUser(
return newEntity;
}
+ public List<UserEntity> listUsersByNamespace(Namespace namespace,
List<Field> skippingFields) {
+ AuthorizationUtils.checkUserNamespace(namespace);
+ String metalakeName = namespace.level(0);
+
+ if (skippingFields.contains(UserEntity.ROLE_IDS)
+ && skippingFields.contains(UserEntity.ROLE_NAMES)) {
Review Comment:
Maybe I can use the annotation to optimize this code. I can update a code
to let you see. The code like
```
@SupportsSkippingFields(RoleEntity, xxx,xxx)
listUserNamepace(xxx)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
