jerryshao commented on code in PR #4942:
URL: https://github.com/apache/gravitino/pull/4942#discussion_r1769506815
##########
catalogs/catalog-lakehouse-hudi/src/main/java/org/apache/gravitino/catalog/lakehouse/hudi/HudiSchemaPropertiesMetadata.java:
##########
@@ -18,14 +18,23 @@
*/
package org.apache.gravitino.catalog.lakehouse.hudi;
-import java.util.Collections;
+import com.google.common.collect.ImmutableMap;
import java.util.Map;
import org.apache.gravitino.connector.BasePropertiesMetadata;
import org.apache.gravitino.connector.PropertyEntry;
public class HudiSchemaPropertiesMetadata extends BasePropertiesMetadata {
+ public static final String LOCATION = "location";
+ private static final Map<String, PropertyEntry<?>> PROPERTIES_METADATA =
+ ImmutableMap.<String, PropertyEntry<?>>builder()
+ .put(
+ LOCATION,
+ PropertyEntry.stringOptionalPropertyEntry(
+ LOCATION, "The directory for Hudi dataset storage", false,
null, false))
Review Comment:
Can we please follow the style to add comment like `/* required */` to the
input variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
