jerryshao commented on code in PR #4320:
URL: https://github.com/apache/gravitino/pull/4320#discussion_r1769511836
##########
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogOperations.java:
##########
@@ -672,4 +721,24 @@ static Path formalizePath(Path path, Configuration
configuration) throws IOExcep
FileSystem defaultFs = FileSystem.get(configuration);
return path.makeQualified(defaultFs.getUri(),
defaultFs.getWorkingDirectory());
}
+
+ private boolean hasCallerContext() {
+ return CallerContext.CallerContextHolder.get() != null
+ && CallerContext.CallerContextHolder.get().context() != null
+ && !CallerContext.CallerContextHolder.get().context().isEmpty();
+ }
+
+ private boolean checkSingleFile(Fileset fileset) {
+ try {
+ Path locationPath = new Path(fileset.storageLocation());
+ return
locationPath.getFileSystem(hadoopConf).getFileStatus(locationPath).isFile();
+ } catch (FileNotFoundException e) {
+ // We should always return false here, same with the logic in
`FileSystem.isFile(Path f)`.
+ return false;
+ } catch (IOException e) {
+ throw new GravitinoRuntimeException(
+ "Exception occurs when checking whether fileset: %s mounts a single
file, exception: %s",
+ fileset.name(), e.getCause());
Review Comment:
I think we can change to like:
```java
throw new GravitinoRuntimeException(e, "xxxxx", xx, xx)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
